Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix registry potential bug #1443

Merged
merged 4 commits into from
May 1, 2022
Merged

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Apr 28, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix registry potential bug, this modification is only an experimental version.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZCMax
Copy link
Collaborator Author

ZCMax commented Apr 28, 2022

This adjustment is only a temporary transition scheme, and the training API of mmdet3d will be refactored later.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1443 (b196639) into dev (c28a3d9) will decrease coverage by 0.38%.
The diff coverage is 18.53%.

❗ Current head b196639 differs from pull request most recent head 3cab2be. Consider uploading reports for the commit 3cab2be to get more accurate results

@@            Coverage Diff             @@
##              dev    #1443      +/-   ##
==========================================
- Coverage   50.69%   50.30%   -0.39%     
==========================================
  Files         219      220       +1     
  Lines       18663    18863     +200     
  Branches     3055     3100      +45     
==========================================
+ Hits         9461     9489      +28     
- Misses       8631     8803     +172     
  Partials      571      571              
Flag Coverage Δ
unittests 50.30% <18.53%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/custom_3d.py 59.86% <5.88%> (-10.94%) ⬇️
mmdet3d/datasets/pipelines/test_time_aug.py 51.04% <11.90%> (-30.44%) ⬇️
mmdet3d/apis/train.py 18.18% <16.81%> (-18.19%) ⬇️
mmdet3d/utils/misc.py 19.04% <19.04%> (ø)
mmdet3d/datasets/semantickitti_dataset.py 87.50% <72.72%> (-12.50%) ⬇️
mmdet3d/utils/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa95955...3cab2be. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants